[Freeciv-Dev] (PR#15135) surrender causes duplicate game-over

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15135 >

If you do /surrender:

* check_for_game_over is called, and passes.  This forces the end of 
sniff, and has several side effects (gamelog and notify_conn).
* sniff_packets ends and check_for_game_over is called again.  Same result.

The end result is everything is done twice.  Bad.

Not sure how best to fix this.  The safest way is to remove 
check_for_game_over from the surrender function.  But this would mean 
surrendering doesn't take effect until the end of the turn.  Harder 
would be to remove the side effects from check_for_game_over.  Or we 
could set GAME_OVER_STATE inside that function, but that risks more side 
effects if changing GAME_OVER_STATE makes other code paths behave 
differently.

-jason