[Freeciv-Dev] (PR#14336) nations bug in civil war

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14336 >

Civil war doesn't use player_set_nation.  This leaves the nations in a 
desynchronized state.

-jason

Index: server/plrhand.c
===================================================================
--- server/plrhand.c    (revision 11131)
+++ server/plrhand.c    (working copy)
@@ -1461,7 +1461,7 @@
 
   /* select a new name and nation for the copied player. */
   /* Rebel will always be an AI player */
-  cplayer->nation = pick_a_nation(civilwar_nations, TRUE, FALSE);
+  player_set_nation(cplayer, pick_a_nation(civilwar_nations, TRUE, FALSE));
   pick_random_player_name(cplayer->nation, cplayer->name);
 
   sz_strlcpy(cplayer->username, ANON_USER_NAME);