[Freeciv-Dev] Re: (PR#14226) Allow_Activity effect

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14226 >

Mateusz Stefek wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=14226 >
> 
> This patch introduces new effect "Allow_Activity". The effect replaces
> the logic of TF_BRIDGE, TF_RAILROAD, TF_FORTRESS and TF_AIRBASE tech flags.
> (TF_FARMLAND will be next).
> 
> This is done by adding new requirement target "ActivityType". 
> The effect targets it's requirements on tile, player and unit.
> Currently "road", "railroad", "fortress" and "airbase" activities are
> supported.
> 
> Part of the effects.ruleset file:

This is bad.  We should do this by making reqs for activities not by 
using effects.  Effects should not be used to make requirements.

-jason