Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2005:
[Freeciv-Dev] Re: (PR#14164) gui-win32: audit game.player_ptr users 		Home

[Freeciv-Dev] Re: (PR#14164) gui-win32: audit game.player_ptr users

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#14164) gui-win32: audit game.player_ptr users
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 7 Oct 2005 10:02:54 -0700
Reply-to: bugs@xxxxxxxxxxx 
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14164 >

Egor Vyscrebentsov wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=14164 >
> 
> On Wed, 5 Oct 2005 16:10:53 -0700
> James Canete <use_less@xxxxxxxxxxx> wrote:
> 
> JC>-  if  (pdialog->pcity->owner != game.player_ptr) {
> JC>+  if  (pdialog->pcity->owner != game.player_ptr || !game.player_ptr) {
> 
> Could pcity->owner be NULL? I thought it couldn't...

pcity->owner may never be NULL.  However if game.player_ptr is NULL then 
you want to draw all cities as if we own them (the user can browse 
through all cities).  So I think this code is corrrect.

-jason
[Prev in Thread] Current Thread [Next in Thread]