[Freeciv-Dev] (PR#14181) citydlg memory leak in popup menu

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14181 >

==31037== 2402 (1688 direct, 714 indirect) bytes in 3 blocks are 
definitely lost in loss record 128 of 158
==31037==    at 0x1B900B88: calloc (vg_replace_malloc.c:279)
==31037==    by 0x1BD8418B: g_malloc0 (in /usr/lib/libglib-2.0.so.0.800.2)
==31037==    by 0x1BD41028: g_type_create_instance (in 
/usr/lib/libgobject-2.0.so.0.800.2)
==31037==    by 0x1BD26720: (within /usr/lib/libgobject-2.0.so.0.800.2)
==31037==    by 0x1BD26DA4: g_object_newv (in 
/usr/lib/libgobject-2.0.so.0.800.2)
==31037==    by 0x1BD2794D: g_object_new_valist (in 
/usr/lib/libgobject-2.0.so.0.800.2)
==31037==    by 0x1BD27AC6: g_object_new (in 
/usr/lib/libgobject-2.0.so.0.800.2)==31037==    by 0x1BA32020: 
gtk_menu_new (gtkmenu.c:1158)
==31037==    by 0x810FA3E: create_city_dialog (citydlg.c:1208)
==31037==    by 0x810D329: popup_city_dialog (citydlg.c:424)
==31037==    by 0x8074CF9: handle_city_packet_common (packhand.c:608)
==31037==    by 0x8074A6C: handle_city_info (packhand.c:541)
==31037==    by 0x807A501: client_handle_packet (packhand_gen.c:102)
==31037==    by 0x8058CC5: handle_packet_input (civclient.c:390)
==31037==    by 0x805D363: input_from_server (clinet.c:342)
==31037==    by 0x8125A12: get_net_input (gui_main.c:1547)
==31037==    by 0x1BBF1168: ??? (gdkevents.c:966)
==31037==    by 0x1BDA6B66: (within /usr/lib/libglib-2.0.so.0.800.2)
==31037==    by 0x1BD7D420: g_main_context_dispatch (in 
/usr/lib/libglib-2.0.so.0.800.2)


This is the line:

   pdialog->popup_menu = gtk_menu_new();

I guess it's not set to be freed when the parent dialog is freed.  But 
this is odd, since it obviously is freed.  Maybe gtk_widget_destroy is 
not the right destructor?

-jason