[Freeciv-Dev] (PR#14179) citydlg memory leak

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14179 >

==28603== 221184 bytes in 1 blocks are possibly lost in loss record 155 
of 159
==28603==    at 0x1B8FF8A6: malloc (vg_replace_malloc.c:149)
==28603==    by 0x1BD842A9: g_try_malloc (in 
/usr/lib/libglib-2.0.so.0.800.2)
==28603==    by 0x1BC71A9D: gdk_pixbuf_new (gdk-pixbuf.c:300)
==28603==    by 0x1BBF7890: gdk_pixbuf_get_from_drawable 
(gdkpixbuf-drawable.c:1278)
==28603==    by 0x81107B8: city_dialog_update_map (citydlg.c:1469)
==28603==    by 0x810D117: refresh_city_dialog (citydlg.c:372)
==28603==    by 0x810FEA8: create_city_dialog (citydlg.c:1293)
==28603==    by 0x810D315: popup_city_dialog (citydlg.c:424)
==28603==    by 0x8074CF9: handle_city_packet_common (packhand.c:608)
==28603==    by 0x8074A6C: handle_city_info (packhand.c:541)
==28603==    by 0x807A501: client_handle_packet (packhand_gen.c:102)
==28603==    by 0x8058CC5: handle_packet_input (civclient.c:390)
==28603==    by 0x805D363: input_from_server (clinet.c:342)
==28603==    by 0x81259E2: get_net_input (gui_main.c:1547)
==28603==    by 0x1BBF1168: ??? (gdkevents.c:966)
==28603==    by 0x1BDA6B66: (within /usr/lib/libglib-2.0.so.0.800.2)
==28603==    by 0x1BD7D420: g_main_context_dispatch (in 
/usr/lib/libglib-2.0.so.0.800.2)
==28603==    by 0x1BD80686: (within /usr/lib/libglib-2.0.so.0.800.2)
==28603==    by 0x1BD80BD7: g_main_loop_run (in 
/usr/lib/libglib-2.0.so.0.800.2)==28603==    by 0x1BA2B988: gtk_main 
(gtkmain.c:1009)
==28603==    by 0x8124CAB: ui_main (gui_main.c:1211)
==28603==    by 0x8058BC9: main (civclient.c:351)

Index: client/gui-gtk-2.0/citydlg.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/citydlg.c,v
retrieving revision 1.141
diff -p -u -r1.141 citydlg.c
--- client/gui-gtk-2.0/citydlg.c        3 Oct 2005 02:50:43 -0000       1.141
+++ client/gui-gtk-2.0/citydlg.c        4 Oct 2005 04:38:09 -0000
@@ -2760,6 +2760,9 @@ static void city_destroy_callback(GtkWid
     gtk_widget_destroy(pdialog->rename_shell);
 
   g_object_unref(pdialog->map_canvas_store);
+  if (pdialog->map_pixbuf_unscaled) {
+    g_object_unref(pdialog->map_pixbuf_unscaled);
+  }
 
   unit_list_iterate(pdialog->pcity->info_units_supported, psunit) {
     free(psunit);