Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2005:
[Freeciv-Dev] (PR#14165) gui-xaw: audit game.player_ptr users
Home

[Freeciv-Dev] (PR#14165) gui-xaw: audit game.player_ptr users

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] (PR#14165) gui-xaw: audit game.player_ptr users
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 2 Oct 2005 20:07:32 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14165 >

All users of game.player_ptr must be checked.  Now with observers this 
value will be NULL at the client.  There are two posible fixes:

1.  Replace it.  When looking at a unit or city, use punit->owner instead.

2.  Special-case it.  A specific check for NULL should make it easy to 
have a separate case.

-jason





[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#14165) gui-xaw: audit game.player_ptr users, Jason Short <=