[Freeciv-Dev] Re: (PR#14144) Data: Nations overhaul step 3, legends

["Daniel Markstedt" <himasaram@xxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14144 >

On 2005-10-01, at 19.56, Christian Knoke wrote:

>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=14144 >
>
> On Fri, Sep 30, 2005 at 03:14:15AM -0700, Daniel Markstedt wrote:
>
> Just two remarks.
>
> ===================================================================
> RCS file: /home/freeciv/CVS/freeciv/data/nation/american.ruleset,v
>
> --- data/nation/american.ruleset      3 Sep 2005 00:58:08 -0000       1.17
> +++ data/nation/american.ruleset      30 Sep 2005 09:47:53 -0000
>
> Americans have filipino as civilwar nation. Sounds funny.
>

I guess the person who put it there was thinking about the Philippines' 
status as a (former) semi-colony of the US. I can remove it in an 
upcoming civil war patch.

> +legend=_("Austria means Eastern Realm, given it's position as the far 
> east territory of the medieval Holy Roman Empire.")
>  leader="Maria Theresia", "Franz Joseph", "Luitpold"
>                                            ^^^^^^^^
> Leopold II. is more specific and correct.
>
> Christian
>

It's a leftover from the "simple" leader names standard of the 1.x 
days. We should standardize on native and correct leader names as you 
say. I could make a patch in ticket #13843 later on. Consistency is 
good.

Daniel