[Freeciv-Dev] (PR#14108) glibc detected *** free(): invalid pointer

["Benedict Adamson" <badamson@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14108 >

The Gtk client of the latest development version crashes because of a 
bad free() when I try to set a particular CMA. The message is this:

glibc detected *** free(): invalid pointer:

here is a backtrace:

#0  0x4053c9e7 in raise () from /lib/tls/libc.so.6
#1  0x4053e31b in abort () from /lib/tls/libc.so.6
#2  0x40573365 in __fsetlocking () from /lib/tls/libc.so.6
#3  0x40579a07 in malloc_usable_size () from /lib/tls/libc.so.6
#4  0x40579ea2 in free () from /lib/tls/libc.so.6
#5  0x08053e4b in attribute_set (key=100000001, id=127, x=-1, y=-1,
     data_length=7, data=0xbfffef50) at attribute.c:328
#6  0x08054278 in attr_city_set (what=0, city_id=0, data_length=0, data=0x0)
     at attribute.c:423
#7  0x080f9c0e in cma_set_parameter (attr=0, city_id=0, parameter=0x8235a8c)
     at cma_core.c:633
#8  0x080f9da2 in cmafec_set_fe_parameter (pcity=0x0, parameter=0x0)
     at cma_fec.c:100
#9  0x081078d4 in cma_activate_preset_callback (view=0x88cc0c0, path=0x0,
     col=0x88ccea0, data=0x88cbb90) at cma_fe.c:510
#10 0x081062b9 in button_press_callback (view=0x88cc0c0, ev=0x870cdd0,
     data=0x88cbb90) at cma_fe.c:145

[Continues]


I guess that hash_delete_entry_full() is incorrectly setting old_key.