Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2005:
[Freeciv-Dev] (PR#13801) Pregame player list broken again
Home

[Freeciv-Dev] (PR#13801) Pregame player list broken again

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mstefek@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#13801) Pregame player list broken again
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 29 Aug 2005 09:04:17 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13801 >

> [jdorje - Mon Aug 29 15:22:15 2005]:
> 
> > [mstefek - Sun Aug 28 09:11:03 2005]:
> > 
> > In the pregame screen, when you add new player the list isn't updated.
> > Also when you change difficulty level or nation of a player nothing is
> > changed on the list. It seems that only lowering aifill really updates
> > the list.
> 
> This patch fixes it.  I will commit immediately.

Actually, *this* patch fixes it (as well as a related problem that
there's no update when a player is removed).

-jason

Index: client/packhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/packhand.c,v
retrieving revision 1.544
diff -p -u -r1.544 packhand.c
--- client/packhand.c   29 Aug 2005 13:56:49 -0000      1.544
+++ client/packhand.c   29 Aug 2005 16:03:25 -0000
@@ -1562,8 +1562,8 @@ void handle_player_info(struct packet_pl
     /* Just about any changes above require an update to the intelligence
      * dialog. */
     update_intel_dialog(pplayer);
-    update_conn_list_dialog();
   }
+  update_conn_list_dialog();
 }
 
 /**************************************************************************
@@ -2002,6 +2002,7 @@ void handle_tile_info(struct packet_tile
 void handle_player_remove(int player_id)
 {
   client_remove_player(player_id);
+  update_conn_list_dialog();
 }
 
 /**************************************************************************

[Prev in Thread] Current Thread [Next in Thread]