Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2005:
[Freeciv-Dev] (PR#13723) barbarian creation starts invalid revolution
Home

[Freeciv-Dev] (PR#13723) barbarian creation starts invalid revolution

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] (PR#13723) barbarian creation starts invalid revolution
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 21 Aug 2005 22:14:25 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13723 >

> [per - Sun Aug 21 10:17:51 2005]:
> 
> On Sat, 20 Aug 2005, Jason Short wrote:
> > The attached patch fixes the crash in the simplest way.This should
> > probably apply to 2.0 also.Note this does change the behavior since
> > the revolution now won't end until the AI sets a government.But maybe
> > that's the intent.
> >
> > Per, please comment.
> 
> At least for 2.1, we should set
> 
>    barbarians->government = nation->init_government;
> 
> instead.

Hmm, are you sure?  Do you mean 2.1 or 2.0?  And, do you mean government
or target_government?

Seems to me we could set either government or target_government to
init_government, at least for 2.0.

-jason




[Prev in Thread] Current Thread [Next in Thread]