Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2005:
[Freeciv-Dev] (PR#13595) pubserver crash: MAP_NCONT is overrun
Home

[Freeciv-Dev] (PR#13595) pubserver crash: MAP_NCONT is overrun

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] (PR#13595) pubserver crash: MAP_NCONT is overrun
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 2 Aug 2005 17:32:34 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13595 >

(gdb) p map.num_continents
$1 = 600

the assertion triggers because there are more than 600 continents!  This 
patch changes the max to be 1024.  However the settings that created 
this bizarre map should be investigated.

-jason


-------- Original Message --------
From: - Tue Aug  2 20:16:53 2005
X-Account-Key: account1
X-UIDL: GmailId10579b1bc37a4da9
X-Mozilla-Status: 0001
X-Mozilla-Status2: 10000000
X-Gmail-Received: d30aea33a7a0771e6c731a32e19f350cee3c93bc
Delivered-To: jdorje@xxxxxxxxx
Received: by 10.54.4.39 with SMTP id 39cs38778wrd;        Tue, 2 Aug 
2005 17:15:55 -0700 (PDT)
Received: by 10.38.104.46 with SMTP id b46mr53256rnc;        Tue, 02 Aug 
2005 17:15:55 -0700 (PDT)
Return-Path: <freeciv-dev-bounce@xxxxxxxxxxx>
Received: from freeciv.freeciv.org (www.freeciv.org [207.158.49.130]) 
      by mx.gmail.com with ESMTP id 71si36427rna.2005.08.02.17.15.53; 
      Tue, 02 Aug 2005 17:15:55 -0700 (PDT)
Received-SPF: pass (gmail.com: best guess record for domain of 
freeciv-dev-bounce@xxxxxxxxxxx designates 207.158.49.130 as permitted 
sender)
Received: from glockenspiel.complete.org (glockenspiel.complete.org 
[69.10.152.57]) by freeciv.freeciv.org (8.12.10/8.12.10) with ESMTP id 
j730FUxB012708; Tue, 2 Aug 2005 17:15:30 -0700
Received: from localhost ([127.0.0.1] helo=glockenspiel)        by 
glockenspiel.complete.org with esmtp    (Exim 4.50)     id 1E06uu-0002Uf-80; 
Tue, 02 Aug 2005 19:15:29 -0500
Received: with ECARTIS (v1.0.0; list freeciv-dev); Tue, 02 Aug 2005 
19:15:19 -0500 (CDT)
Received: from pubserver.freeciv.org ([207.158.49.131]) by 
glockenspiel.complete.org with esmtps   (with 
TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24)    (No TLS peer certificate)       (Exim 
4.50)   id 1E06ug-0002UW-Uc     for freeciv-dev@xxxxxxxxxxx; Tue, 02 Aug 2005 
19:15:19 -0500
Received: from pubserver.freeciv.org (localhost.localdomain 
[127.0.0.1])    by pubserver.freeciv.org (8.12.8/8.12.8) with ESMTP id 
j730Ew2R010083  for <freeciv-dev@xxxxxxxxxxx>; Tue, 2 Aug 2005 17:14:58 -0700
Received: (from freeciv@localhost)      by pubserver.freeciv.org 
(8.12.8/8.12.8/Submit) id j730Ew2G010081        for freeciv-dev@xxxxxxxxxxx; 
Tue, 2 Aug 2005 17:14:58 -0700
Date: Tue, 2 Aug 2005 17:14:58 -0700
From: freeciv@xxxxxxxxxxxxxxxxxxxxx
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] civserver crashed: 
http://pubserver.freeciv.org/games/459314
Message-ID: <20050802171458.A10079@xxxxxxxxxxxxxxxxxxxxx>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="bp/iNruPH9dso1Pn"
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
X-Spam-Status: No (score 0.2): AWL=0.003, NO_REAL_NAME=0.178
X-Virus-Scanned: by Exiscan on glockenspiel.complete.org at Tue, 02 Aug 
2005 19:15:19 -0500
X-archive-position: 1240
X-ecartis-version: Ecartis v1.0.0
Sender: freeciv-dev-bounce@xxxxxxxxxxx
Errors-to: freeciv-dev-bounce@xxxxxxxxxxx
X-original-sender: freeciv@xxxxxxxxxxxxxxxxxxxxx
Precedence: bulk
List-help: <mailto:ecartis@xxxxxxxxxxx?Subject=help>
List-unsubscribe: 
<mailto:freeciv-dev-request@xxxxxxxxxxx?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: <freeciv-dev.freeciv.org>
X-List-ID: <freeciv-dev.freeciv.org>
List-subscribe: <mailto:freeciv-dev-request@xxxxxxxxxxx?Subject=subscribe>
List-owner: <mailto:freeciv-dev-admins@xxxxxxxxxxx>
List-post: <mailto:freeciv-dev@xxxxxxxxxxx>
X-list: freeciv-dev
X-Spam-Status: No (score 0.2): AWL=0.003, NO_REAL_NAME=0.178
X-Virus-Scanned: by Exiscan on glockenspiel.complete.org at Tue, 02 Aug 
2005 19:15:29 -0500



# examining core.27933 in /games/459314/. ...
# using $FREECIV_PATH 
:/home/freeciv/.freeciv/code/installed/cvs/S2_0/2005-08-02_09.00+mintimeout+original_gamelog/share/freeciv
# running: (echo bt full; echo quit; exec yes '') | gdb  
/home/freeciv/.freeciv/code/installed/cvs/S2_0/2005-08-02_09.00+mintimeout+original_gamelog/share/freeciv/../../bin/civserver
 core.27933
GNU gdb Red Hat Linux (5.2-2)
Copyright 2002 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i386-redhat-linux"...
Core was generated by 
`/home/freeciv/.freeciv/code/installed/cvs/S2_0/2005-08-02_09.00+mintimeout+orig'.
Program terminated with signal 6, Aborted.
Reading symbols from /lib/libm.so.6...done.
Loaded symbols for /lib/libm.so.6
Reading symbols from /usr/lib/libz.so.1...done.
Loaded symbols for /usr/lib/libz.so.1
Reading symbols from /lib/libc.so.6...done.
Loaded symbols for /lib/libc.so.6
Reading symbols from /lib/ld-linux.so.2...done.
Loaded symbols for /lib/ld-linux.so.2
Reading symbols from /usr/lib/gconv/ISO8859-1.so...done.
Loaded symbols for /usr/lib/gconv/ISO8859-1.so
Reading symbols from /lib/libnss_files.so.2...done.
Loaded symbols for /lib/libnss_files.so.2
Reading symbols from /lib/libnss_nisplus.so.2...done.
Loaded symbols for /lib/libnss_nisplus.so.2
Reading symbols from /lib/libnsl.so.1...done.
Loaded symbols for /lib/libnsl.so.1
Reading symbols from /lib/libnss_dns.so.2...done.
Loaded symbols for /lib/libnss_dns.so.2
Reading symbols from /lib/libresolv.so.2...done.
Loaded symbols for /lib/libresolv.so.2
#0  0x400760a1 in kill () from /lib/libc.so.6
(gdb) #0  0x400760a1 in kill () from /lib/libc.so.6
No symbol table info available.
#1  0x40075e99 in raise () from /lib/libc.so.6
No symbol table info available.
#2  0x40077364 in abort () from /lib/libc.so.6
No symbol table info available.
#3  0x4007015d in __assert_fail () from /lib/libc.so.6
No symbol table info available.
#4  0x0806b30c in assign_continent_numbers (skip_unsafe=true) at maphand.c:164
        ter = 6
        ptile = (struct tile *) 0x40450d98
        _index = 26821
        i = 138493824
#5  0x0810061d in create_start_positions (mode=MT_DEFAULT) at startpos.c:195
        ptile = (struct tile *) 0x0
        k = 0
        sum = -1073746352
        data = {count = -1314621513, min_value = -2129691826, 
  value = 0x3b1328a7}
        tile_value_aux = (int (*)[0]) 0xbffe2b90
        tile_value = (int (*)[0]) 0xbffc6990
        min_goodies_per_player = 2000
        total_goodies = 0
        efactor = 0
#6  0x080fcbba in map_fractal_generate (autosize=true) at mapgen.c:1121
        rstate = {v = {3006373574, 2400477171, 3516280782, 2466987667, 
    3885061098, 1819280179, 2842272625, 1659933131, 3405455040, 1719973051, 
    2774695670, 192727861, 3598788370, 3447646632, 1612274025, 911326670, 
    1164138078, 2763110538, 934089668, 3540265416, 1914619070, 219383678, 
    811538075, 2341122844, 2302461489, 1011750715, 1733008931, 3160327490, 
    2374275519, 1849991835, 3358341863, 1750448832, 3540497665, 2571293958, 
    52868002, 582003532, 130162260, 3183422323, 122074653, 152615239, 
    1953389555, 4247166092, 1832189703, 1035103676, 2980345783, 2165275470, 
    991111335, 3488959992, 4246304385, 3683104668, 3211689967, 1660782175, 
    2073033745, 2561217108, 1362857904, 157105088}, j = 10, k = 41, x = 9, 
  is_init = true}
#7  0x0804fdf7 in srv_loop () at srv_main.c:1827
        i = 138493824
        start_nations = 6
#8  0x0804fa8d in srv_main () at srv_main.c:1674
No locals.
#9  0x0804a5f0 in main (argc=14, argv=0xbffff054) at civserver.c:200
        argc = 14
        argv = (char **) 0xbffff054
        inx = 14
        showhelp = false
        showvers = false
        option = 0x0
#10 0x400651c4 in __libc_start_main () from /lib/libc.so.6
No symbol table info available.
(gdb) [... 0 lines skipped ...]


Index: server/maphand.h
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/maphand.h,v
retrieving revision 1.48.2.3
diff -p -u -r1.48.2.3 maphand.h
--- server/maphand.h    15 Feb 2005 17:41:58 -0000      1.48.2.3
+++ server/maphand.h    3 Aug 2005 00:32:19 -0000
@@ -50,7 +50,7 @@ struct player_tile {
 };
 
 /* The maximum number of continents and oceans. */
-#define MAP_NCONT 600
+#define MAP_NCONT 1024
 
 void assign_continent_numbers(bool skip_unsafe);
 

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#13595) pubserver crash: MAP_NCONT is overrun, Jason Short <=