[Freeciv-Dev] (PR#13386) got a select nation packet in an incompatible state

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13386 >

This message shows up in the client when connecting to a server.

  "got a select nation packet in an incompatible state"

the reason is the server sends availability packets for observer and
barbarian nations, which the client doesn't expect.  I don't know if
it's necessary to send these packets but it can't harm anything.  The
attached patch just lets the client handle it.

-jason

Index: client/packhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/packhand.c,v
retrieving revision 1.525
diff -u -r1.525 packhand.c
--- client/packhand.c   21 Jun 2005 16:21:00 -0000      1.525
+++ client/packhand.c   30 Jun 2005 18:32:23 -0000
@@ -2003,7 +2003,7 @@
                             bool is_unavailable, bool is_used)
 {
   if (get_client_state() == CLIENT_PRE_GAME_STATE
-      && nation_no >= 0 && nation_no < game.control.playable_nation_count) {
+      && nation_no >= 0 && nation_no < game.control.nation_count) {
     struct nation_type *nation = get_nation_by_idx(nation_no);
     const bool changed = (nation->is_unavailable != is_unavailable
                          || nation->is_used != is_used);