[Freeciv-Dev] Re: (PR#13340) Owner change and happyborders

["Benoit Hudson" <bh@xxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13340 >

On Mon, Jun 27, 2005 at 05:32:47AM -0700, Mateusz Stefek wrote:
> +         hash_insert(cities_to_refresh, &(homecity->id), NULL);

Why not put in homecity?

> +    for (i = 0; i < entries; i++) {
> +      int id = *(int*)hash_key_by_number(cities_to_refresh, i);

This is O(n^2): look at the implementation of hash_key_by_number.

Probably Per is right: a list or vector would do perfectly well despite
their quadratic time, since we will only be having a small number of
cities.

        -- Benoît