[Freeciv-Dev] Re: (PR#13270) init_available_nations

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13270 >

Vasco Alexandre da Silva Costa wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13270 >
> 
> On Tue, 21 Jun 2005, [UTF-8] Thomas Müller wrote:
> 
>><URL: http://bugs.freeciv.org/Ticket/Display.html?id=13270 >
>>
>>Am Dienstag, 21. Juni 2005 11:17 schrieb Mateusz Stefek:
>>
>>><URL: http://bugs.freeciv.org/Ticket/Display.html?id=13270 >
>>>
>>>It looks like the client doesn't cross out nonavailable nations.
>>>But the server rejects wrong nations and the function which chooses
>>>random nation works as it should
>>
>>Also, you can chose a nation, somebody else has already chosen. The clientside
>>crossing out seems to be disfunctional.
> 
> It used to work, but that GUI code was changed recently. Do not know if
> whoever did the change tested that properly.

Problem is crossing out is only designed to be done when the window is
open - which in the old design it always was.  In the new design you
have to cross out nations when the selection dialog is first open too.
Mateusz's patch does this in an inefficient way; it would also be
possible to put the info straight into the list the first time it's
filled out.  I had a patch to do this but I seem to have lost it.

-jason