[Freeciv-Dev] (PR#13164) Illegal BV_SET() usage at diplomats.c

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13164 >

> [cazfi - Sun May 22 21:08:56 2005]:
> 
> 
>   Debug compilation for diplomats.c fails due to BV_SET() in 
> spy_get_sabotage_list()
> 
>   Second argument for BV_SET() is number of bit to set, not wheter bit 
> should be set or cleared as this code seems to expect.

Ahh, of course (though I don't see how this causes a compile warning).

-jason

Index: server/diplomats.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/diplomats.c,v
retrieving revision 1.77
diff -u -r1.77 diplomats.c
--- server/diplomats.c  22 May 2005 17:48:11 -0000      1.77
+++ server/diplomats.c  25 May 2005 03:47:26 -0000
@@ -212,7 +212,9 @@
   BV_CLR_ALL(packet.improvements);
 
   impr_type_iterate(i) {
-    BV_SET(packet.improvements, city_got_building(pcity, i));
+    if (city_got_building(pcity, i)) {
+      BV_SET(packet.improvements, i);
+    }
   } impr_type_iterate_end;
 
   packet.diplomat_id = pdiplomat->id;