[Freeciv-Dev] (PR#13144) Show and hide dead players in the players dialog

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13144 >

> [mstefek - Thu May 19 19:59:22 2005]:
> 
> With the attached patch the players dialog can hide or display rows 
> with  dead players.  
> This was requested by many.  

Good idea, but I think the code in options.c can be improved.

We have two basic types of options.  "General options", GEN_BOOL_OPTION,
are automatically put into the options dialog and automatically saved
and loaded.  "View options", VIEW_OPTION(), are strictly boolean options
that are controlled through menu checkboxes - they are not put into the
options dialog but are still saved and loaded automatically.  The latter
is probably a misnomer (currently it's used entirely for mapview options
but there's no particular reason for this).

So, in summary you should put this new option into one of the above
categories.  I don't really care which one.

As a side note the other manually-controlled options in options.c should
also be put into one of these categories.

-jason