[Freeciv-Dev] (PR#13049) ruleset effects cache has two negated fields

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13049 >

> [jdorje - Thu May 12 20:53:35 2005]:
> 
> There's a 'neg' and 'negated' field.  Seems the latter is unused.

Here is a patch.

Index: common/effects.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/common/effects.c,v
retrieving revision 1.43
diff -u -u -r1.43 effects.c
--- common/effects.c    11 May 2005 00:13:22 -0000      1.43
+++ common/effects.c    14 May 2005 22:33:22 -0000
@@ -431,12 +431,12 @@
   unsigned id = 0;
 
   effect_list_iterate(ruleset_cache.tracker, peffect) {
-    struct packet_ruleset_effect packet;
+    struct packet_ruleset_effect effect_packet;
 
-    packet.effect_type = peffect->type;
-    packet.effect_value = peffect->value;
+    effect_packet.effect_type = peffect->type;
+    effect_packet.effect_value = peffect->value;
 
-    lsend_packet_ruleset_effect(dest, &packet);
+    lsend_packet_ruleset_effect(dest, &effect_packet);
 
     requirement_list_iterate(peffect->reqs, preq) {
       struct packet_ruleset_effect_req packet;
@@ -450,6 +450,7 @@
       packet.source_value = value;
       packet.range = range;
       packet.survives = survives;
+      packet.negated = FALSE;
 
       lsend_packet_ruleset_effect_req(dest, &packet);
     } requirement_list_iterate_end;
@@ -466,6 +467,7 @@
       packet.source_value = value;
       packet.range = range;
       packet.survives = survives;
+      packet.negated = FALSE;
 
       lsend_packet_ruleset_effect_req(dest, &packet);
     } requirement_list_iterate_end;