[Freeciv-Dev] (PR#13028) problem with loading a savegame in-game

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13028 >

Connect to a running server and do /load.  Now when you start the game
all aspects of your nation are wrong.

This patch fixes the problem.  The problem is the rulesets are resent on
the /load (which is unnecessary but certainly not buggy).  The
ruleset-control packet tells the client to free all its nations "in
expectation" of receiving new ones.  But because the nation packet is
marked is_info and the nation hasn't changed, the server decides not to
send any packet.  Thus all the client's nations are empty.

As a side note I think we should get rid of is_info.  It causes bugs and
saves only a few bytes of network data.

-jason

Index: common/packets.def
===================================================================
RCS file: /home/freeciv/CVS/freeciv/common/packets.def,v
retrieving revision 1.119
diff -u -r1.119 packets.def
--- common/packets.def  7 May 2005 14:03:51 -0000       1.119
+++ common/packets.def  10 May 2005 16:44:08 -0000
@@ -1137,7 +1137,7 @@
   UINT8 fallout_tile_penalty[O_MAX]; /* % taken from output if polluted */
 end
 
-PACKET_RULESET_NATION=102;sc,lsend,is-info
+PACKET_RULESET_NATION=102;sc,lsend
   NATION id; key
 
   STRING name[MAX_LEN_NAME];