[Freeciv-Dev] Re: (PR#13005) latest CVS (assertion failed, effects.c)

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13005 >

On Sat, 7 May 2005, Jason Short wrote:

> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13005 >
>
> Brian Dunstan wrote:
> > <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13005 >
> >
> > Using the latest CVS, compiled with
> > --enable-debug=yes, and the attached save game,
> > attempting to build the first welsh city results in
> > the following:
> >
> > brian: '/start'
> > Starting game.
> > 2: brian rules the Welsh.
> > 2: Stefan Batory has been added as easy level
> > AI-controlled player.
> >
> >>save welsh_crash
> >
> > Game saved as welsh_crash.sav.gz
> >
> >>civserver: effects.c:768:
> >
> > get_city_tile_output_bonus: Assertion `pcity != ((void
> > *)0) && ptile != ((void *)0)' failed.
> > Aborted
>
> My mistake.  This assertion should have been removed (the tile is often
> NULL).

The code should be robust enough to accept any parameter as NULL. There
should be no asserts for the arguments on the get_*_bonus functions.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa