[Freeciv-Dev] Re: (PR#13003) tile_activity patch

["Brian Dunstan" <bdunstan149@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13003 >

OK, v.2 of the patch has changes 1. - 3.

Since tile_irrigate, etc, are now static, these calls
have been replaced with tile_apply_activity elsewhere
in the  freeciv code.

--- Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> <URL:
> http://bugs.freeciv.org/Ticket/Display.html?id=13003
> >
> 
> Brian Dunstan wrote:
> > <URL:
> http://bugs.freeciv.org/Ticket/Display.html?id=13003
> >
> > 
> > This patch adds a function
> > 
> > tile_activity(tile, activity)
> 
> Seems reasonable.  I think it should be
> tile_apply_activity or
> tile_do_activity instead.
> 
> > The patch I've made is one implementation; I'm
> sure
> > others can think of some way it might be done
> better :)
> 
> 1.  I think the functions tile_transform, etc.,
> should be made static.
> 
> 2.  Don't have a "default" case.
> 
> 3.  Don't manipulate ptile->special directly.  Use
> map_set_special or
> map_clear_special.
> 
> -jason
> 
> 
> 
> 
> 

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com