[Freeciv-Dev] Re: (PR#12017) observer start game, cvs head crash

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12017 >

On Tue, Jan 25, 2005 at 03:45:44PM -0800, Per I. Mathisen wrote:
> 
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12017 >
> 
> Bug 1: You can start a game with only an observer as a player. I believe
> this to be a bug.

agree. here's a patch.

-mike

Index: server/stdinhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/stdinhand.c,v
retrieving revision 1.354.2.24
diff -u -r1.354.2.24 stdinhand.c
--- server/stdinhand.c  22 Jan 2005 20:23:08 -0000      1.354.2.24
+++ server/stdinhand.c  29 Jan 2005 16:39:22 -0000
@@ -3597,7 +3597,8 @@
     }
 
     /* check min_players */
-    if (game.nplayers < game.min_players) {
+    if (game.nplayers < game.min_players ||
+        (game.nplayers == 1 && game.players[0].is_observer == TRUE)) {
       cmd_reply(CMD_START_GAME, caller, C_FAIL,
                _("Not enough players, game will not start."));
       return FALSE;