Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2005:
[Freeciv-Dev] (PR#12016) Pubserver civserver crash in diplomacy 		Home

[Freeciv-Dev] (PR#12016) Pubserver civserver crash in diplomacy

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: paul@xxxxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#12016) Pubserver civserver crash in diplomacy
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 25 Jan 2005 16:57:23 -0800
Reply-to: bugs@xxxxxxxxxxx 
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12016 >

I think this fix is incomplete.  The check for invalid clauses should be
done in the handle_* function, not in the iteration.  Otherwise we risk
having an error elsewhere where clauses are handled.  Invalid requests
from the client should always be discarded within the handle_* function.

-jason
[Prev in Thread] Current Thread [Next in Thread]