[Freeciv-Dev] (PR#11972) gtk2-client memory leak in create_city_dialog

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11972 >

This leak is in the gtk2 client in the dev branch.  I dunno if it's in 
the S2_0 branch as well.

==23942== 352 bytes in 2 blocks are definitely lost in loss record 94 of 153
==23942==    at 0x1B907901: calloc (vg_replace_malloc.c:176)
==23942==    by 0x1BD7E4CE: g_malloc0 (in /usr/lib/libglib-2.0.so.0.400.8)
==23942==    by 0x1BD30119: g_type_create_instance (in 
/usr/lib/libgobject-2.0.so.0.400.8)
==23942==    by 0x1BD1A73E: (within /usr/lib/libgobject-2.0.so.0.400.8)
==23942==    by 0x1BD19ECD: g_object_newv (in 
/usr/lib/libgobject-2.0.so.0.400.8)
==23942==    by 0x1BD1A70D: g_object_new_valist (in 
/usr/lib/libgobject-2.0.so.0.400.8)
==23942==    by 0x1BD19B95: g_object_new (in 
/usr/lib/libgobject-2.0.so.0.400.8)
==23942==    by 0x1BA40316: gtk_menu_new (in 
/usr/lib/libgtk-x11-2.0.so.0.400.14)
==23942==    by 0x81007B0: create_city_dialog (citydlg.c:1237)
==23942==    by 0x80FE028: popup_city_dialog (citydlg.c:432)
==23942==    by 0x8085868: handle_city_packet_common (packhand.c:616)
==23942==    by 0x808549B: handle_city_info (packhand.c:536)
==23942==    by 0x8089AF9: client_handle_packet (packhand_gen.c:115)
==23942==    by 0x80705BA: handle_packet_input (civclient.c:371)
==23942==    by 0x8073B3E: input_from_server (clinet.c:340)
==23942==    by 0x1BC1019A: (within /usr/lib/libgdk-x11-2.0.so.0.400.14)
==23942==    by 0x1BD9D2BE: (within /usr/lib/libglib-2.0.so.0.400.8)
==23942==    by 0x1BD77C01: (within /usr/lib/libglib-2.0.so.0.400.8)
==23942==    by 0x1BD78CF7: g_main_context_dispatch (in 
/usr/lib/libglib-2.0.so.0.400.8)
==23942==    by 0x1BD7902F: (within /usr/lib/libglib-2.0.so.0.400.8)
==23942==    by 0x1BD79672: g_main_loop_run (in 
/usr/lib/libglib-2.0.so.0.400.8)
==23942==    by 0x1BA37C82: gtk_main (in 
/usr/lib/libgtk-x11-2.0.so.0.400.14)
==23942==    by 0x811667C: ui_main (gui_main.c:1200)
==23942==    by 0x806FDD9: main (civclient.c:339)

-jason