[Freeciv-Dev] (PR#11932) ngettext isn't recognized when compiling with libintl

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=11932 >

When compiling with libintl, the ngettext function isn't found.

The problem spewed by config.log is that some iconv functions are 
undefined.  Indeed, the iconv check is done way below the gettext check 
even though iconv is used by gettext (but not the other way around). 
Looking at libintl.la, libiconv.la is listed as a dependency...so the 
check should succeed.  But it doesn't.  Another oddness is that the 
gettext function is found, no problem.

I think it is safe to move the iconv checks up.  It may even solve the 
auto-compilation problems that the daily snapshots have been having (I 
have no idea how to test this).

-jason

Index: configure.ac
===================================================================
RCS file: /home/freeciv/CVS/freeciv/configure.ac,v
retrieving revision 1.80.2.7
diff -u -r1.80.2.7 configure.ac
--- configure.ac        9 Dec 2004 03:32:11 -0000       1.80.2.7
+++ configure.ac        15 Jan 2005 09:56:21 -0000
@@ -148,6 +148,18 @@
 dnl Programs already checked by AM_INIT_AUTOMAKE:
 dnl  AC_PROG_MAKE_SET
 
+dnl Check for libiconv (which is usually included in glibc, but may be
+dnl distributed separately).  The libcharset check must come after the
+dnl iconv check.  This whole thing must come before the gettext check below.
+AM_ICONV
+AM_LIBCHARSET
+AM_LANGINFO_CODESET
+if test "$am_cv_func_iconv" != yes; then
+  AC_MSG_ERROR([Iconv is missing.  You can get it from http://gnu.org/, \
+                or try using --with-libiconv-prefix.])
+fi
+LIBS="$LIBS $LIBICONV"
+
 dnl I18n support
 ALL_LINGUAS="ca cs da de en_GB es et fi fr he_IL hu it ja nl no pl pt pt_BR ro 
ru sv uk"
 AM_GNU_GETTEXT(,need-ngettext)
@@ -327,19 +339,6 @@
      FTWL_LIBS=`sdl-config --libs`" -lpng "`freetype-config --libs`
 fi
 
-dnl Check for libiconv (which is usually included in glibc, but may be
-dnl distributed separately).  The libcharset check must come after the
-dnl iconv check.  Langinfo_codeset is already checked in gettext but we
-dnl don't rely on that (since we use it ourselves).
-AM_ICONV
-AM_LIBCHARSET
-AM_LANGINFO_CODESET
-if test "$am_cv_func_iconv" != yes; then
-  AC_MSG_ERROR([Iconv is missing.  You can get it from http://gnu.org/, \
-                or try using --with-libiconv-prefix.])
-fi
-LIBS="$LIBS $LIBICONV"
-
 dnl Check and choose clients
 if test x$client != xno; then