Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#11213) Making client headers compatible with C++

[Freeciv-Dev] Re: (PR#11213) Making client headers compatible with C++

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#11213) Making client headers compatible with C++
From: "Frédéric Brière" <fbriere@xxxxxxxxxxx>
Date: Wed, 15 Dec 2004 10:30:25 -0800
Reply-to: bugs@xxxxxxxxxxx

<URL: >

On Wed, Dec 15, 2004 at 09:34:25AM -0800, Vasco Alexandre da Silva Costa wrote:
> As I said before, I'm ok with variable renaming or adding casts to void
> pointers, etc. What I am *not* ok with is adding "#ifdef __cplusplus" all over
> the common code, or other C++ specific features. The common code is 100% C

Please, Vasco, I've only proposed *one* such addition.  Qualifying this
as "all over" is a tad melodramatic...


  toroia:~# grep -r __cplusplus freeciv | wc -l

So, nyah! <g>

I do agree that my patch for #11282 is superficial, and that it might be
better to "fix" it at the source.  You actually never did reply to my
last comment on that ticket, but feel free to do so if you're still
uncomfortable with the original patch.  I'd much rather argue about a
patch than letting it rot away.

(As for casting void pointers, maybe you could convince Jason that
#11283 is not as evil as he seems to think?)

             Frédéric Brière    <*>    fbriere@xxxxxxxxxxx

 =>  <fbriere@xxxxxxxxxx> IS NO MORE:  <>  <=

[Prev in Thread] Current Thread [Next in Thread]