Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#11357) Re: (PR#11358) server crash in aitools.c 		Home

[Freeciv-Dev] Re: (PR#11357) Re: (PR#11358) server crash in aitools.c

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx, kaufman@xxxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#11357) Re: (PR#11358) server crash in aitools.c
From: "Marko Lindqvist" <marko.lindqvist@xxxxxxxxxxx>
Date: Sun, 5 Dec 2004 17:23:29 -0800
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=11357 >

Mike Kaufman wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=11357 >
> 
> On Sun, Dec 05, 2004 at 04:45:53PM -0800, Marko Lindqvist wrote:
> 
>>   We've got autosettler on city building mission.
> 
> for reference, this player had just been aitoggled from ai to human.

  And unit roles are not reset when player is aitoggled. So settler has 
kept its previous AIUNIT_BUILD_CITY role. Obviously unit roles should be 
reseted. Is there any special cases where they should be preserved?
  Probably also auto_settler_findwork() should be made a bit more 
secure. It currently believes that if settler has AIUNIT_BUILD_CITY 
role, it has to be AI player unit. Extra check here can't hurt.


  - ML
[Prev in Thread] Current Thread [Next in Thread]