Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2004:
[Freeciv-Dev] Re: (PR#11276) [C++] client/tilespec.h refers to an enum c 		Home

[Freeciv-Dev] Re: (PR#11276) [C++] client/tilespec.h refers to an enum c

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: fbriere@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#11276) [C++] client/tilespec.h refers to an enum constant out of scope
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 1 Dec 2004 14:04:11 -0800
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=11276 >

Vasco Alexandre da Silva Costa wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=11276 >
> 
> On Wed, 1 Dec 2004, [UTF-8] Frédéric Brière wrote:
> 
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=11276 >
>>
>>This patch moves the enum out as discussed, and obsoletes the original
>>patch.
> 
> This is a nit, but since you are renaming class -> category everywhere,
> perhaps it would be better to use category here as well?

That would be fine too.  The term "category" was originally use for 
server settings.  It makes sense to use it (in exactly the same way) for 
client options.  Using it for nations and citizens is a bit more arbitrary.

-jason
[Prev in Thread] Current Thread [Next in Thread]