[Freeciv-Dev] Re: (PR#11281) [C++] forward enum declaration in common/fc
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
|
Subject: |
[Freeciv-Dev] Re: (PR#11281) [C++] forward enum declaration in common/fc_types.h |
|
From: |
"Frédéric Brière" <fbriere@xxxxxxxxxxx> |
|
Date: |
Wed, 1 Dec 2004 11:43:45 -0800 |
|
Reply-to: |
rt@xxxxxxxxxxx |
<URL: http://rt.freeciv.org/Ticket/Display.html?id=11281 >
On Wed, Dec 01, 2004 at 11:32:47AM -0800, Vasco Alexandre da Silva Costa wrote:
> > - Moving the enum before the typedef
> >
> > - Moving the typedef after the enum
>
> Either are ok by me.
Unfortunately, this is a bit more difficult (though I admit it's much
more elegant). I think you'd object to moving city-specific enums out
of city.h, so this would call for moving the typedef from fc_types.h to
city.h, and requiring files that #include fc_types.h and depend on these
typedefs to #include city.h as well.
(This seems to run contrary to what fc_types was created for, from what
I can gather from its comments, but there we are.)
If you agree on the solution, I'll gladly provide a patch.
--
Frédéric Brière <*> fbriere@xxxxxxxxxxx
=> <fbriere@xxxxxxxxxx> IS NO MORE: <http://www.abacomsucks.com> <=
|
|
