[Freeciv-Dev] (PR#11271) get_food_trade_shields isn't good

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=11271 >

What is the purpose of the get_food_trade_shields() function?

This function should be moved out of city.c and into aicity.c.  It's 
only purpose AFAICT is to do a "quick" estimation of output in place of 
generic_city_refresh.  In fact I think it's buggy because the caller 
(city_want) doesn't account for specialists, and neither does 
get_food_trade_shields().

-jason