[Freeciv-Dev] Re: (PR#10831) 1: unexpected exit from tabular at u2.id (civgame-3400m.sav.gz)

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10831 >

On Mon, Nov 01, 2004 at 07:40:01PM -0800, Jason Short wrote:
> 
> I believe this is an error in the registry code.  This is an old error 
> but it only shows up with "new" ways of using the registry.  I have no 
> idea how to fix it, nor I believe does anywone else.

I guess we could always ask dwp to fix it. here's a patch to give us some
additional logging and maybe avoid a segfault.

-mike

Index: utility/registry.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/utility/registry.c,v
retrieving revision 1.67
diff -u -r1.67 registry.c
--- utility/registry.c  7 Sep 2004 08:04:16 -0000       1.67
+++ utility/registry.c  4 Nov 2004 02:12:26 -0000
@@ -732,8 +732,9 @@
          /* break out of tabular if doesn't match: */
          if((!pentry) || (strcmp(pentry->name, expect) != 0)) {
            if(icol != 0) {
-             freelog(LOG_ERROR, "unexpected exit from tabular at %s (%s)",
-                     pentry->name, real_filename);
+             freelog(LOG_ERROR, "unexpected exit from tabular at %s "
+                                 "(expected: %s) (%s)",
+                     pentry ? "nil" : pentry->name, expect, real_filename);
              fz_fprintf(fs, "\n");
            }
            fz_fprintf(fs, "}\n");