[Freeciv-Dev] (PR#10657) player_dlg must have a column for username

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10657 >

> [jdorje - Mon Oct 25 06:39:44 2004]:
> 
> +  if (has_capability("username_info", aconnection.capability)) {
> +    sz_strlcpy(pplayer->username, pinfo->username);
> +  } else {
> +    conn_list_iterate(game.est_connections, pconn) {
> +      if (pconn->player == pplayer && !pconn->observer) {
> +        sz_strlcpy(pplayer->username, pconn->username);
> +      }
> +    } conn_list_iterate_end;
> +  }
> 
> But if it's as easy as finding the conn matching the player why do we
> need a new network field at all?

Good question. I even wonder why we have a plr->username field in CVS in
the first place. Is it because it must be saved or something like that?