[Freeciv-Dev] Re: (PR#10387) Xaw client segfaults on middle button click on map

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10387 >

Egor Vyscrebentsov via RT wrote:
> <URL: http://RT::WebBaseURL.not.configured:80/Ticket/Display.html?id=10387 >
> 
> CVS 2004-09-29 21:07 + 0400, Xaw client.
> 
> Xaw client segfaults if you click mouse middle button on map tile.
> Reproducible every time.

Does this fix it?

jason

Index: client/gui-xaw/mapctrl.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-xaw/mapctrl.c,v
retrieving revision 1.88
diff -u -r1.88 mapctrl.c
--- client/gui-xaw/mapctrl.c    29 Sep 2004 02:24:22 -0000      1.88
+++ client/gui-xaw/mapctrl.c    29 Sep 2004 18:57:01 -0000
@@ -159,7 +159,7 @@
     XtVaSetValues(p, XtNx, x, XtNy, y, NULL);
 
     *cross_head = NULL;
-    for (i = 0; cross_list[i] >= 0; i++) {
+    for (i = 0; cross_list[i]; i++) {
       put_cross_overlay_tile(cross_list[i]);
     }
     XtAddCallback(p,XtNpopdownCallback,popupinfo_popdown_callback,