[Freeciv-Dev] (PR#10295) crazy code in citymap

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10295 >

In citymap.c and citymap.h:

1.  The citymap array is itself way bigger than needed.  LIke all other 
map arrays it should be indexed by index.

2.  This code in citymap.c:67

           citymap[ptile->index] = citymap[ptile->index]++;

is surely very wrong.

3. In citymap.c:73 it looks like it's never checked whether the goto 
dest is set.  But this would cause an assertion if it weren't true.  So 
I'm confused.

That's about it.

jason