[Freeciv-Dev] (PR#10236) Allied cities shown without reason

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10236 >

> [imbaczek@xxxxxxxxx - Tue Sep 21 16:07:56 2004]:
> 
> See attached screenshot. This happened just after the AI broke an
> alliance with me.
> 
> Linux 2.6.8
> Debian testing
> Freeciv CVS 2004-09-20
> GTK2 client
> 
> 
Do you have a savegame?

Probably a bug in remove_allied_visibility()

Do you have a savegame?
Does this patch help?
--
mateusz

Index: unittools.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/unittools.c,v
retrieving revision 1.303
diff -u -r1.303 unittools.c
--- unittools.c 14 Sep 2004 03:29:22 -0000      1.303
+++ unittools.c 21 Sep 2004 16:46:23 -0000
@@ -1344,7 +1344,9 @@
     /* The player used to know what units were in these cities.  Now that he
      * doesn't, he needs to get a new short city packet updating the
      * occupied status. */
-    send_city_info(pplayer, pcity);
+    if (map_is_known_and_seen(pcity->x, pcity->y, pplayer)) {
+      send_city_info(pplayer, pcity);
+    }
   } city_list_iterate_end;
 }