[Freeciv-Dev] Re: (PR#10155) refresh of LAN list causes crash

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=10155 >

Jason Short wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=10155 >
> 
> In the gtk2 client, when I go to the LAN list in the connectdlg and 
> refresh, the list pops up for an instant and then it crashes.

Vasco found the problem.  It's the same as PR#9975.  Here's a fix.

jason

? client/tilespec.diff
Index: client/gui-gtk-2.0/connectdlg.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/connectdlg.c,v
retrieving revision 1.43
diff -u -r1.43 connectdlg.c
--- client/gui-gtk-2.0/connectdlg.c     16 Sep 2004 00:12:21 -0000      1.43
+++ client/gui-gtk-2.0/connectdlg.c     17 Sep 2004 02:59:00 -0000
@@ -258,7 +258,6 @@
 
     server_list_iterate(*server_list, pserver) {
       GtkTreeIter it;
-      int i;
 
       row[0] = pserver->name;
       row[1] = pserver->port;
@@ -271,10 +270,6 @@
       gtk_list_store_set(storelan, &it,
                         0, row[0], 1, row[1], 2, row[2],
                         3, row[3], 4, row[4], 5, row[5], -1);
-
-      for (i = 0; i < 6; i++) {
-       g_free(row[i]);
-      }
     } server_list_iterate_end;
   }