[Freeciv-Dev] Re: (PR#9627) PATCH: correct some parameters in map generator and clean-up

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9627 >

Le mar 07/09/2004 à 10:49, Mateusz Stefek a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9627 >
> 
> > [mstefek - Tue Sep 07 08:13:28 2004]:
> > 
> > > [mburda - Tue Sep 07 07:44:43 2004]:
> > > 
> > > > [jdorje - Mar. Aoû. 10 01:39:25 2004]:
> > > 
> > > UPATED
> > > Finally this is time to go for this patch
> > > comments welcomed
> > > i think someting is wrong with rivers but i no see what
> > > 
> > > TO FIX rivers problem
> 
> >From make_rivers():
>   /* Formula to make the river density similar om different sized maps.
> Avoids
>      too few rivers on large maps and too many rivers on small maps. */
>   int desirable_riverlength =
>     map.riverlength *
>     /* This 10 is a conversion factor to take into account the fact that
> this
>      * river code was written when map.riverlength had a maximum value of 
>      * 1000 rather than the current 100 */
>     10 *
>     /* The size of the map (poles don't count). */
>     map_num_tiles() 
>       * (map.alltemperate ? 1.0 : 2.0 * ICE_BASE_LEVEL/MAX_TEMP) *
>     /* Rivers need to be on land only. */
>     map.landpercent /
>     /* Adjustment value. Tested by me. Gives no rivers with 'set
>        rivers 0', gives a reasonable amount of rivers with default
>        settings and as many rivers as possible with 'set rivers 100'. */
>     0xD000; /* (= 53248 in decimal) */
> 
Hi, i find the error this ( fix it in a test version and i forget to
copy it there 
 * (map.alltemperate ? 1.0 : 2.0 * ICE_BASE_LEVEL/MAX_TEMP) *
has to be
 * (map.alltemperate ? 1.0 : 1,0 - 2.0 * ICE_BASE_LEVEL/MAX_TEMP) *
but after reread it i think this as to be fixed as a pct value not a
amount value, i will do it and i will send a new patch.
> If map.alltemperature = 0 then desirable_river_length = 7
> Something is wrong in this formula
> when alltemperature = 1 rivers look normal.
> 
> > > Marcelo
> > > 
> > It doesn't apply
> Sorry, I didn't run cvs update
> --
> mateusz
>