[Freeciv-Dev] Re: (PR#9951) warning compiling without readline

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9951 >

Jason Short wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9951 >
> 
> When I compile without readline I get a warning that olvlname_accessor 
> is defined but not used.
> 
> I'm not sure why this doesn't happen for the other accessor functions. 
> I didn't look that closely.  Something like this should fix it (but 
> again I didn't look that closely).

Ok, this should actually fix it.

I tested it with --with-readline and --without-readline.  However I 
don't know what would happen if you tried to compile with "old" readline 
(HAVE_LIBREADINE but not HAVE_NEWLIBREADLINE).  I suspect you can't 
compile Freeciv with old readline anymore...

jason

Index: server/stdinhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/stdinhand.c,v
retrieving revision 1.343
diff -u -r1.343 stdinhand.c
--- server/stdinhand.c  4 Sep 2004 20:36:10 -0000       1.343
+++ server/stdinhand.c  5 Sep 2004 17:58:04 -0000
@@ -1265,6 +1265,7 @@
   return settings[i].name;
 }
 
+#if defined HAVE_LIBREADLINE || defined HAVE_NEWLIBREADLINE
 /**************************************************************************
   Returns possible parameters for the /show command.
 **************************************************************************/
@@ -1277,6 +1278,7 @@
     return settings[i-OLEVELS_NUM].name;
   }
 }
+#endif
 
 /**************************************************************************
   Set timeout options.