[Freeciv-Dev] (PR#9952) valgrind reports error in zlib

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9952 >

I got this warning:

==21336==    at 0x8138002: longest_match (deflate.c:966)
==21336==    by 0x8137AEF: deflate_slow (deflate.c:1422)
==21336==    by 0x81365BF: deflate (deflate.c:630)
==21336==    by 0x8134353: compress2 (compress.c:49)
==21336==    by 0x80C8C9E: send_packet_data (packets.c:160)
==21336==    by 0x80D3AD4: send_packet_chat_msg_100 (packets_gen.c:4621)
==21336==    by 0x80D3CA1: send_packet_chat_msg (packets_gen.c:4676)
==21336==    by 0x8086455: vnotify_conn_ex (plrhand.c:1212)
==21336==    by 0x80864AD: notify_conn (plrhand.c:1236)
==21336==    by 0x806BBF7: establish_new_connection (connecthand.c:94)
==21336==    by 0x806C7C3: handle_login_request (connecthand.c:351)
==21336==    by 0x804F47B: handle_packet_input (srv_main.c:892)
==21336==    by 0x80A50A0: sniff_packets (sernet.c:616)
==21336==    by 0x8050701: srv_loop (srv_main.c:1606)
==21336==    by 0x80505FE: srv_main (srv_main.c:1565)
==21336==    by 0x804A289: main (civserver.c:170)

A ridiculous amount of time later, I believe I have traced this to a bug 
within zlib.  However I did find a few freeciv bugs in the process...

I only mention this because if anyone else thinks to try to run the 
server under valgrind and track down the errors: don't bother with this one.

jason