Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2004:
[Freeciv-Dev] Re: (PR#9898) civserver crashes on multiple games with dif
Home

[Freeciv-Dev] Re: (PR#9898) civserver crashes on multiple games with dif

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#9898) civserver crashes on multiple games with different sizes
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>
Date: Wed, 1 Sep 2004 21:25:42 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9898 >

On Wed, 1 Sep 2004, Jason Short wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9898 >
>
> Run the server with a map of size 1.
>
> Then don't exit the server, but run it again on a map of size 29.
>
> Boom!
>
> One culprit is local_vector in gotohand.c:find_the_shortest_path().
> This patch fixes that.  But I think there are other problems also.

Is compiler clever enough to make local_vector static.  Otherwise,
re-allocating it every time might be expensive.  On the other hand, the
memory is not cleared, so probably it's ok.

I would still do a few runs, just to see.

G.




[Prev in Thread] Current Thread [Next in Thread]