[Freeciv-Dev] (PR#9533) win32: real_append_output_window is overcomplicated

["James Canete" <use_less@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9533 >

> [jdorje - Wed Jul 28 22:12:32 2004]:
> 
> real_append_output_window has a mildly ugly hack to handle adding \r 
> onto the end of a line.  But the string it's given is guaranteed to be 
> just one line, so this isn't needed (but adding an assertion to 
> guarantee it is probably a good idea).
> 

I tried adding "assert (strchr(astring, '\n') == NULL);", and it turns
out there are a couple places where append_output_window() receives a
multiline argument, like this in gui-win32/gui_main.c:

  append_output_window(_("Freeciv is free software and you are welcome
to distribute copies of"
                         " it\nunder certain conditions; See the \"Copying\" 
item on the Help"
                         " menu.\nNow.. Go give'em hell!") );

A similar call is in each of the other guis, but I haven't done an
indepth search for any others.

-James Canete