[Freeciv-Dev] (PR#9798) PATCH assign_continent_number_count size of cont
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://rt.freeciv.org/Ticket/Display.html?id=9798 >
> [mburda - Tue Aug 24 19:55:44 2004]:
> depend de 9796
> This is used by 9627 patch to clean easy small isle or oceans
The idea seems good. I'm not quite sure how you plan to use it but it
seems obvious that the data should be useful. Only problem is with the
ugly (but workable) indexing hack you use.
Another question I have is if we really want to extend the use of
MAP_NCONT. Originally this was just a hack to get gen2 (?) to work.
But now it's extended to be a hard limit on the number of continents.
While more than 300 continents doesn't seem likely it would be easy to
make a scenario with it.
Also the name MAP_NCONT is bad. It should be MAX_NUM_CONTINENTS.
- Rename MAP_NCONT as MAX_NUM_CONTINENTS. Possibly make it bigger.
- Remove the value entirely and dynamically size any necessary arrays.