[Freeciv-Dev] (PR#9741) Problem inside setup_isledata() (not really important)

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9741 >

Hamilton's method is even worse. It favours small island too much. See:
http://freeciv.org/~matusik/hamilton.png

Also small islands get too much goodies (because ocean counts too).

1: isl 1 go 0
1: isl 2 go 1795
1: isl 3 go 97
1: isl 4 go 94
1: isl 5 go 519
1: isl 6 go 1038
1: isl 7 go 133
1: isl 8 go 114
1: isl 9 go 270
1: isl 10 go 121
1: isl 11 go 1464
1: isl 12 go 2134
1: isl 13 go 363
1: isl 14 go 172
1: isl 15 go 231
1: isl 16 go 165
1: isl 17 go 0
1: isl 1 st 0
1: isl 2 st 6
1: isl 3 st 0
1: isl 4 st 0
1: isl 5 st 2
1: isl 6 st 4
1: isl 7 st 1
1: isl 8 st 0
1: isl 9 st 1
its twice as 7!
1: isl 10 st 0
1: isl 11 st 5
1: isl 12 st 7
1: isl 13 st 1
1: isl 14 st 1
1: isl 15 st 1
1: isl 16 st 1
1: isl 17 st 0


I found another bug. In gen1 and gen2 remove_tiny_islands() is called
_after_ assigne continent numbers. And since is_tiny_island() checks
only cardinally adjacent tiles it can divide continents and confuse
setup_isledata().
--
mateusz