[Freeciv-Dev] Re: (PR#9801) is_server_runing is always TRUE

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9801 >

Jason Short wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9801 >
> 
> I get this warning when compiling under gcc 3.4:
> 
> connectdlg_common.c: In function `disconnected_from_local_server':
> connectdlg_common.c:433: warning: the address of `is_server_running', 
> will always evaluate as `true'
> 
> (I think this was already reported by Mateusz.)

Err, actually this is an unrelated and minor bug.

jason

Index: client/connectdlg_common.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/connectdlg_common.c,v
retrieving revision 1.20
diff -u -r1.20 connectdlg_common.c
--- client/connectdlg_common.c  24 Aug 2004 23:13:26 -0000      1.20
+++ client/connectdlg_common.c  25 Aug 2004 00:13:14 -0000
@@ -430,7 +430,7 @@
 void disconnected_from_local_server() 
 {
   char buf[1024];
-  assert(is_server_running);
+  assert(is_server_running());
   my_snprintf(buf, sizeof(buf), 
               _("A local server is still running on port %d. Use "
                 "\"Connect to Network Game\" to connect to it."),