Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2004:
[Freeciv-Dev] Re: (PR#9761) replace enum tile_terrain_type with Terrain_
Home

[Freeciv-Dev] Re: (PR#9761) replace enum tile_terrain_type with Terrain_

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#9761) replace enum tile_terrain_type with Terrain_type_id
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 22 Aug 2004 15:55:26 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9761 >

Gregory Berkolaiko wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9761 >
> 
> On Sun, 22 Aug 2004, Jason Short wrote:
> 
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=9761 >
>>
>>I sent this before but I think RT was broken.
>>
>>-------- Original Message --------
>>Subject: replace enum tile_terrain_type with Terrain_type_id
>>Date: Sun, 22 Aug 2004 14:04:44 -0400
>>From: Jason Dorje Short <jdorje@xxxxxxxxxxxx>
>>To: rt@xxxxxxxxxxxxxx
>>
>>This patch replaces users of the enum tile_terrain_type type with a
>>Terrain_type_id typedef.  This corresponds to what is done in
>>improvement.h with Improvement_type_id.  Eventually this enum can be
>>removed and we can just have an integer value here.
>>
>>The patch is easy to recreate.  Run
>>
>>    replace.sh "enum tile_terrain_type" Terrain_type_id
>>
>>then replace the terrain.h changes with the given patch.
> 
> 
> We now have fc_types.h ...

I guess you're saying this type should go into fc_types.h?

But that's not possible without moving the enumeration as well, which I 
don't think we should do.  Once the enumeration goes away it will be 
easily moved.  (Same is true with Tech_type_id, Unit_type_id, 
Improvement_type_id....)

jason




[Prev in Thread] Current Thread [Next in Thread]