[Freeciv-Dev] Re: (PR#9710) no readline support for show command

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9710 >

Gregor Richards wrote:


> -  /* 
> +  /*

Garbage.

> -          "the percent chance of \"occupying\" territory."), NULL, 
> +          "the percent chance of \"occupying\" territory."), NULL,

Garbage.

> - /* easy */  H_RATES | H_TARGETS | H_HUTS | H_NOPLANES 
> + /* easy */  H_RATES | H_TARGETS | H_HUTS | H_NOPLANES

Garbage.

> +static const char *olvlname_accessor(int i) {
> +  // for 0->4, uses option levels, otherwise returns a setting name

Don't use //.  Use /* */.

> +    return settings[i-OLEVELS_NUM].name;

"Bad" style.

> +/**************************************************************************
> +...
> +**************************************************************************/

Please write a reasonable comment for the function.

jason