[Freeciv-Dev] Re: (PR#4712) Comments about version.diff

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=4712 >

Marko Lindqvist wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=4712 >
> 
> Jason Short wrote:
> 
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=4712 >
>>
>>What about this line in configure.in/configure.ac:
>>  VERSION=${MAJOR_VERSION}.${MINOR_VERSION}.${PATCH_VERSION}${VERSION_LABEL}
>>
>>this requires that configure.* knows what the version # is.  AFAIK this 
>>is needed so "make dist" works.
> 
> 
>   configure.* gets those definitions by including version.in, that's the 
> whole point of this patch! (You probably missed that 
> 'm4_include(version.in)' had '+' and not '-' in front of it in diff)

Yes, I was confusing version.m4 and version.in.

>>Also, what does this line do:
>>
>>+AC_SUBST([CONFIGURE_DEPENDENCIES], ['$(top_srcdir)/version.in'])
>>
> 
> 
>   It's automake feature (since version 1.4) that causes configure 
> -script to be rebuild whenever version.in changes, just like it is 
> rebuilt when configure.ac changes.
>   Before this patch version changes were written directly to configure.* 
> and that caused configure to be rebuilt. We move version information out 
> of configure.* -> they no longer change when version changes -> 
> configure is not rebuilt. Above line reverts that by effectively saying 
> to automake that version.in should be considered as part of configure.*
>   This all probably requires --enable-maintainer-mode to work at all, I 
> have not tested otherwise.

Will this overwrite other configure dependencies (AFAIK there are no 
other configure dependencies, but...).

jason