[Freeciv-Dev] (PR#9696) failed generating map (gen2); savegame causes crash

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9696 >

With the attached rc file all sorts of bad things happen.

==4303== Invalid write of size 4
==4303==    at 0x81362CA: ai_best_government (aihand.c:302)
==4303==    by 0x8132EEC: ai_data_turn_init (aidata.c:294)
==4303==    by 0x813309B: ai_data_get (aidata.c:344)
==4303==    by 0x80A26DB: player_save (savegame.c:2085)
==4303==    by 0x80A8D23: game_save (savegame.c:3383)
==4303==    by 0x804F59B: save_game (srv_main.c:678)
==4303==    by 0x807DCAB: create_start_positions (mapgen.c:1510)
==4303==    by 0x805118E: srv_loop (srv_main.c:1716)
==4303==    by 0x8050CD1: srv_main (srv_main.c:1531)
==4303==    by 0x804A5DE: main (civserver.c:161)
==4303==  Address 0x1BB0A294 is 0 bytes after a block of size 4 alloc'd
==4303==    at 0x1B904EDD: malloc (vg_replace_malloc.c:131)
==4303==    by 0x804B1A2: fc_real_malloc (mem.c:79)
==4303==    by 0x804B297: fc_real_calloc (mem.c:124)
==4303==    by 0x81330FB: ai_data_init (aidata.c:358)
==4303==    by 0x808AB74: server_player_init (plrhand.c:1523)
==4303==    by 0x8052A7B: create_ai_player (stdinhand.c:2167)
==4303==    by 0x8059603: handle_stdin_input (stdinhand.c:4501)
==4303==    by 0x80A9FB3: handle_readline_input_callback (sernet.c:173)
==4303==    by 0x1B93B560: rl_callback_read_char (in 
/lib/libreadline.so.4.3)
==4303==    by 0x80AAE20: sniff_packets (sernet.c:559)
==4303==    by 0x8050DBD: srv_loop (srv_main.c:1572)
==4303==    by 0x8050CD1: srv_main (srv_main.c:1531)
==4303==    by 0x804A5DE: main (civserver.c:161)

==4303== Invalid read of size 4
==4303==    at 0x81363E1: ai_best_government (aihand.c:316)
==4303==    by 0x8132EEC: ai_data_turn_init (aidata.c:294)
==4303==    by 0x813309B: ai_data_get (aidata.c:344)
==4303==    by 0x80A26DB: player_save (savegame.c:2085)
==4303==    by 0x80A8D23: game_save (savegame.c:3383)
==4303==    by 0x804F59B: save_game (srv_main.c:678)
==4303==    by 0x807DCAB: create_start_positions (mapgen.c:1510)
==4303==    by 0x805118E: srv_loop (srv_main.c:1716)
==4303==    by 0x8050CD1: srv_main (srv_main.c:1531)
==4303==    by 0x804A5DE: main (civserver.c:161)
==4303==  Address 0x1BB0A294 is 0 bytes after a block of size 4 alloc'd
==4303==    at 0x1B904EDD: malloc (vg_replace_malloc.c:131)
==4303==    by 0x804B1A2: fc_real_malloc (mem.c:79)
==4303==    by 0x804B297: fc_real_calloc (mem.c:124)
==4303==    by 0x81330FB: ai_data_init (aidata.c:358)
==4303==    by 0x808AB74: server_player_init (plrhand.c:1523)
==4303==    by 0x8052A7B: create_ai_player (stdinhand.c:2167)
==4303==    by 0x8059603: handle_stdin_input (stdinhand.c:4501)
==4303==    by 0x80A9FB3: handle_readline_input_callback (sernet.c:173)
==4303==    by 0x1B93B560: rl_callback_read_char (in 
/lib/libreadline.so.4.3)
==4303==    by 0x80AAE20: sniff_packets (sernet.c:559)
==4303==    by 0x8050DBD: srv_loop (srv_main.c:1572)
==4303==    by 0x8050CD1: srv_main (srv_main.c:1531)
==4303==    by 0x804A5DE: main (civserver.c:161)

==4303== Invalid read of size 4
==4303==    at 0x8136442: ai_best_government (aihand.c:321)
==4303==    by 0x8132EEC: ai_data_turn_init (aidata.c:294)
==4303==    by 0x813309B: ai_data_get (aidata.c:344)
==4303==    by 0x80A26DB: player_save (savegame.c:2085)
==4303==    by 0x80A8D23: game_save (savegame.c:3383)
==4303==    by 0x804F59B: save_game (srv_main.c:678)
==4303==    by 0x807DCAB: create_start_positions (mapgen.c:1510)
==4303==    by 0x805118E: srv_loop (srv_main.c:1716)
==4303==    by 0x8050CD1: srv_main (srv_main.c:1531)
==4303==    by 0x804A5DE: main (civserver.c:161)
==4303==  Address 0x1BB0A294 is 0 bytes after a block of size 4 alloc'd
==4303==    at 0x1B904EDD: malloc (vg_replace_malloc.c:131)
==4303==    by 0x804B1A2: fc_real_malloc (mem.c:79)
==4303==    by 0x804B297: fc_real_calloc (mem.c:124)
==4303==    by 0x81330FB: ai_data_init (aidata.c:358)
==4303==    by 0x808AB74: server_player_init (plrhand.c:1523)
==4303==    by 0x8052A7B: create_ai_player (stdinhand.c:2167)
==4303==    by 0x8059603: handle_stdin_input (stdinhand.c:4501)
==4303==    by 0x80A9FB3: handle_readline_input_callback (sernet.c:173)
==4303==    by 0x1B93B560: rl_callback_read_char (in 
/lib/libreadline.so.4.3)
==4303==    by 0x80AAE20: sniff_packets (sernet.c:559)
==4303==    by 0x8050DBD: srv_loop (srv_main.c:1572)
==4303==    by 0x8050CD1: srv_main (srv_main.c:1531)
==4303==    by 0x804A5DE: main (civserver.c:161)

==4303== Invalid read of size 4
==4303==    at 0x8136473: ai_best_government (aihand.c:323)
==4303==    by 0x8132EEC: ai_data_turn_init (aidata.c:294)
==4303==    by 0x813309B: ai_data_get (aidata.c:344)
==4303==    by 0x80A26DB: player_save (savegame.c:2085)
==4303==    by 0x80A8D23: game_save (savegame.c:3383)
==4303==    by 0x804F59B: save_game (srv_main.c:678)
==4303==    by 0x807DCAB: create_start_positions (mapgen.c:1510)
==4303==    by 0x805118E: srv_loop (srv_main.c:1716)
==4303==    by 0x8050CD1: srv_main (srv_main.c:1531)
==4303==    by 0x804A5DE: main (civserver.c:161)
==4303==  Address 0x1BB0A2A0 is 12 bytes after a block of size 4 alloc'd
==4303==    at 0x1B904EDD: malloc (vg_replace_malloc.c:131)
==4303==    by 0x804B1A2: fc_real_malloc (mem.c:79)
==4303==    by 0x804B297: fc_real_calloc (mem.c:124)
==4303==    by 0x81330FB: ai_data_init (aidata.c:358)
==4303==    by 0x808AB74: server_player_init (plrhand.c:1523)
==4303==    by 0x8052A7B: create_ai_player (stdinhand.c:2167)
==4303==    by 0x8059603: handle_stdin_input (stdinhand.c:4501)
==4303==    by 0x80A9FB3: handle_readline_input_callback (sernet.c:173)
==4303==    by 0x1B93B560: rl_callback_read_char (in 
/lib/libreadline.so.4.3)
==4303==    by 0x80AAE20: sniff_packets (sernet.c:559)
==4303==    by 0x8050DBD: srv_loop (srv_main.c:1572)
==4303==    by 0x8050CD1: srv_main (srv_main.c:1531)
==4303==    by 0x804A5DE: main (civserver.c:161)

==4303== Process terminating with default action of signal 11 (SIGSEGV): 
dumping core
==4303==  Access not within mapped region at address 0x4
==4303==    at 0x81362CA: ai_best_government (aihand.c:302)
==4303==    by 0x8132EEC: ai_data_turn_init (aidata.c:294)
==4303==    by 0x813309B: ai_data_get (aidata.c:344)
==4303==    by 0x80A26DB: player_save (savegame.c:2085)
==4303==    by 0x80A8D23: game_save (savegame.c:3383)
==4303==    by 0x804F59B: save_game (srv_main.c:678)
==4303==    by 0x807DCAB: create_start_positions (mapgen.c:1510)
==4303==    by 0x805118E: srv_loop (srv_main.c:1716)
==4303==    by 0x8050CD1: srv_main (srv_main.c:1531)
==4303==    by 0x804A5DE: main (civserver.c:161)

At first I thought this was related to PR#9695 but now I'm not sure.

jason

set generator 2
set aifill 30
hard
create b
set randseed 1092420324
set seed 1273465463
start