Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2003:
[Freeciv-Dev] (PR#6999) possible send_all_known_cities/send_city_info_at
Home

[Freeciv-Dev] (PR#6999) possible send_all_known_cities/send_city_info_at

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: per@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#6999) possible send_all_known_cities/send_city_info_at_tile bug
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 30 Nov 2003 10:57:13 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6999 >

> [per - Sun Nov 30 18:45:31 2003]:
> 
> I think this core needs to be properly investigated by whoever wrote
> this piece of code.

Sorry - nobody here but us chickens.

Looks like this happens when there is a connection with no associated
player.  There is code to handle this, but it is incomplete.  Thus
update_dumb_city is called with pplayer==NULL and an immediate segfault
occurrs.

The obvious fix is that the dumb city shouldn't be updated for
non-players.  But apparently it shouldn't be possible to have non-player
connections, so we need to track down how that's happening as well.

jason



[Prev in Thread] Current Thread [Next in Thread]