[Freeciv-Dev] Re: (PR#6980) worklists disappear in gtk client

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6980 >

On Fri, Nov 28, 2003 at 04:35:08PM -0800, Genevieve Gracian wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=6980 >
> 
> Hello,
> 
> On the gtk client when setting a worklist for a city, the worklist
> disappears at closing city dialog (close dialog button or prev/next city
> buttons) and only the 1st item is remaining.

The worklists aren't sent to the client at all.

> This doesn't happens with the gtk2 client.

It looks like the gtk2 worklist editor works in a different way
(setting is_valid to TRUE instead of coping the values from the city's
worklist).

Patch which got applied is attached.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I heard if you play the NT-4.0-CD backwards, you get a satanic message."
 "That's nothing, if you play it forward, it installs NT-4.0"

Index: common/worklist.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/common/worklist.c,v
retrieving revision 1.16
diff -u -u -r1.16 worklist.c
--- common/worklist.c   2003/11/28 17:37:21     1.16
+++ common/worklist.c   2003/11/29 11:25:52
@@ -212,6 +212,9 @@
 {
   int i, len = worklist_length(wlist1);
 
+  if (wlist1->is_valid != wlist2->is_valid) {
+    return FALSE;
+  }
   if (worklist_length(wlist2) != len) {
     return FALSE;
   }